Uploaded image for project: 'GMAT'
  1. GMAT
  2. GMT-3424

When editing a script in Script Editor, GMAT saves errors

    Details

      Description

      Load any script and create and error in the script. GMAT will throw an error letting you know there is an error in the script when you hit Save/Sync. If you close the window then reopen it GMAT will tell you there is an error in the script. This means that GMAT saved the error.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            shughes Steven Hughes added a comment -

            CCB: P1 R2013a The button says "Save" and it saved. So this does not seem like a bug. Are we missing something?

            Show
            shughes Steven Hughes added a comment - CCB: P1 R2013a The button says "Save" and it saved. So this does not seem like a bug. Are we missing something?
            Hide
            shoffman Shawn Hoffman added a comment -

            I expected the behavior would be similar to when you hit the Apply button on a panel. If there are errors in a panel when you hit the Apply button GMAT doesn't apply/save them to the object; GMAT restores the object to the most recent valid state. I think it would make sense that GMAT would throw the error and allow the user to fix the error but saving the error doesn't make sense since the user will get another error message when trying to load the script. Obviously the script shouldn't be reverted because the user would lose all their changes, but in my opinion overwriting a valid script with an invalid one does not seem like the correct behavior.

            Show
            shoffman Shawn Hoffman added a comment - I expected the behavior would be similar to when you hit the Apply button on a panel. If there are errors in a panel when you hit the Apply button GMAT doesn't apply/save them to the object; GMAT restores the object to the most recent valid state. I think it would make sense that GMAT would throw the error and allow the user to fix the error but saving the error doesn't make sense since the user will get another error message when trying to load the script. Obviously the script shouldn't be reverted because the user would lose all their changes, but in my opinion overwriting a valid script with an invalid one does not seem like the correct behavior.
            Hide
            shughes Steven Hughes added a comment -

            If we changed behavior, if you have an invalid script, you could not save it. Say its the end of the day and you made a change that is bad and you need to save and go and figure it out later. We should not disallow that.

            Show
            shughes Steven Hughes added a comment - If we changed behavior, if you have an invalid script, you could not save it. Say its the end of the day and you made a change that is bad and you need to save and go and figure it out later. We should not disallow that.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: