Uploaded image for project: 'GMAT'
  1. GMAT
  2. GMT-3190

Comment command in script editor doesn't comment last line of selection

    Details

      Description

      1. Load the attached script.
      2. Drag your mouse across the first 4 lines, such that only part of line 4 is selected.
      3. Type CTRL+R or click Edit > Comment
      4. Only the first 3 lines are commented.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            shughes Steven Hughes added a comment -

            CCB: P1 R2013a.

            Show
            shughes Steven Hughes added a comment - CCB: P1 R2013a.
            Hide
            tgrubb Thomas Grubb added a comment -

            Note that GMAT has a problem with this file because it is "corrupt". What I mean is that if you look at the file in Notepad++, the line endings are just random (sometimes CR, sometimes LF). Regular GMAT files, CRLF, work. The StyledTextEditor seems to have a problem with this randomness. Even setting the EOLMode doesn't set the text properly. I had to change the code to look for either CR or LF to make Comment/Uncomment work.

            Show
            tgrubb Thomas Grubb added a comment - Note that GMAT has a problem with this file because it is "corrupt". What I mean is that if you look at the file in Notepad++, the line endings are just random (sometimes CR, sometimes LF). Regular GMAT files, CRLF, work. The StyledTextEditor seems to have a problem with this randomness. Even setting the EOLMode doesn't set the text properly. I had to change the code to look for either CR or LF to make Comment/Uncomment work.
            Hide
            jjkparker Joel Parker added a comment -

            So this is unfixable if the file has mixed line endings? That's fine, I just want to make sure.

            I'm seeing a lot of mixed line endings creeping into my files after I edit them with the script editor (2012-10-25 build). I haven't nailed it down, but it looks like there's still a bug in there somewhere. I'll put a bug in if I can ever figure out a clean way to duplicate it.

            Show
            jjkparker Joel Parker added a comment - So this is unfixable if the file has mixed line endings? That's fine, I just want to make sure. I'm seeing a lot of mixed line endings creeping into my files after I edit them with the script editor (2012-10-25 build). I haven't nailed it down, but it looks like there's still a bug in there somewhere. I'll put a bug in if I can ever figure out a clean way to duplicate it.
            Hide
            tgrubb Thomas Grubb added a comment -

            Actually, it is fixed and will be in the 2012-11-08 build. However, I am concerned that this may bite us somewhere else.

            Show
            tgrubb Thomas Grubb added a comment - Actually, it is fixed and will be in the 2012-11-08 build. However, I am concerned that this may bite us somewhere else.
            Hide
            tgrubb Thomas Grubb added a comment -

            Fixed in Build 2012-11-08

            Show
            tgrubb Thomas Grubb added a comment - Fixed in Build 2012-11-08
            Hide
            jjkparker Joel Parker added a comment -

            Verified as fixed using 2013-01-14 build. Reassigning to Tom for any further GUI testing.

            Show
            jjkparker Joel Parker added a comment - Verified as fixed using 2013-01-14 build. Reassigning to Tom for any further GUI testing.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: