Uploaded image for project: 'GMAT'
  1. GMAT
  2. GMT-2976

Syntax highlighting is incomplete

    Details

      Description

      This is an impression-of-quality issue.

      The syntax highlighting in the script editor is incomplete.

      This needs a more thorough inspection, but here's some things I see from looking at the Hohmann sample:

      • DifferentialCorrector is blue, but Spacecraft, Propagator, ForceModel, etc. aren't
      • MaxStep is blue, but no other fields of Propagator are
      • true/false are blue, but yes/no and on/off aren't
      • Comments aren't highlighted
      • keywords in comments are highlighted
      • Vary command Lower option is highlighted, but Perturbation isn't
      • transpose operator is highlighted like a mismatched string quote

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            shughes Steven Hughes added a comment -

            CCB: JJKP and TGG need to determine two items what syntax highlighting is support that we think is "good", and then how long it will take to fix it. We will then retriage given the estimate.

            See EditorPreferences.*pp for some customization options.

            Show
            shughes Steven Hughes added a comment - CCB: JJKP and TGG need to determine two items what syntax highlighting is support that we think is "good", and then how long it will take to fix it. We will then retriage given the estimate. See EditorPreferences.*pp for some customization options.
            Hide
            shughes Steven Hughes added a comment -

            Please reset fix by to be empty when estimates are added to this ticket.

            Show
            shughes Steven Hughes added a comment - Please reset fix by to be empty when estimates are added to this ticket.
            Hide
            jjkparker Joel Parker added a comment -

            Tom, let me know when you're ready to start looking into this, and maybe we can sit down and talk about what we want to end up with.

            Show
            jjkparker Joel Parker added a comment - Tom, let me know when you're ready to start looking into this, and maybe we can sit down and talk about what we want to end up with.
            Hide
            jjkparker Joel Parker added a comment -

            These things should be highlighted:

            • comments without internal highlighting
            • literals (numbers, strings, booleans)
            • keywords (GMAT)
            • commands (If, Propagate, For, BeginMissionSequence)
            • resources (Spacecraft, Variable, Array)

            There's at least one edge case that I know of: x = y' + 8' should NOT be highlighted as a string.

            It might be best to start with a MATLAB syntax file, since our languages are so similar.

            This needs to work with both .script and .m files, but both being interpreted as GMAT scripts. No need for highlighting for any other language.

            Show
            jjkparker Joel Parker added a comment - These things should be highlighted: comments without internal highlighting literals (numbers, strings, booleans) keywords (GMAT) commands (If, Propagate, For, BeginMissionSequence) resources (Spacecraft, Variable, Array) There's at least one edge case that I know of: x = y' + 8' should NOT be highlighted as a string. It might be best to start with a MATLAB syntax file, since our languages are so similar. This needs to work with both .script and .m files, but both being interpreted as GMAT scripts. No need for highlighting for any other language.
            Hide
            tgrubb Thomas Grubb added a comment -

            Fixed since 2012-10-01 using Matlab lexer. Will add enhancement for GMAT Lexer at later date

            Show
            tgrubb Thomas Grubb added a comment - Fixed since 2012-10-01 using Matlab lexer. Will add enhancement for GMAT Lexer at later date
            Hide
            jjkparker Joel Parker added a comment -

            Verified as fixed using 2012-12-20 build.

            Show
            jjkparker Joel Parker added a comment - Verified as fixed using 2012-12-20 build.
            Hide
            jjkparker Joel Parker added a comment -

            Tom, close when the enhancement is checked in.

            Show
            jjkparker Joel Parker added a comment - Tom, close when the enhancement is checked in.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: