Uploaded image for project: 'GMAT'
  1. GMAT
  2. GMT-2896

Loading script with vary command in optimize opens buggy vary panel

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: P1
    • Resolution: Invalid
    • Affects Version/s: None
    • Fix Version/s: R2013a
    • Component/s: Vary Command (FRC-2)
    • Labels:
      None
    • Environment:

      I am using the June 29 version of GMAT on Windows 7

      Description

      To replicate this bug, load the attached script. Go to the mission tree and open the Vary command. You will notice that all fields are active. When using the SQP optimizer, the Perturbation and Max Step fields should be inactive.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              shughes Steven Hughes added a comment -

              CCB: P1 2013a

              Show
              shughes Steven Hughes added a comment - CCB: P1 2013a
              Hide
              shoffman Shawn Hoffman added a comment -

              Script to load to see bug

              Show
              shoffman Shawn Hoffman added a comment - Script to load to see bug
              Hide
              djcinsb Darrel Conway added a comment -

              Note to self: The script here is an fmincon script, so must be debugged on Windows

              Show
              djcinsb Darrel Conway added a comment - Note to self: The script here is an fmincon script, so must be debugged on Windows
              Hide
              djcinsb Darrel Conway added a comment -

              The issue here is a scripting error, not a GUI panel error. The user has scripted the command like this:

              Vary DefaultDC(DefaultIB.Element1 = 0.5,

              {Perturbation = 0.0001, Lower = 0.0, Upper = 3.14159, MaxStep = 0.2}

              );

              and has defined DefaultDC like this:

              Create DifferentialCorrector DefaultDC;

              The scripting of the Vary command is not for an SQP optimizer, and the Vary panel is interpreting the panel settings correctly for a Differential Corrector.

              Show
              djcinsb Darrel Conway added a comment - The issue here is a scripting error, not a GUI panel error. The user has scripted the command like this: Vary DefaultDC (DefaultIB.Element1 = 0.5, {Perturbation = 0.0001, Lower = 0.0, Upper = 3.14159, MaxStep = 0.2} ); and has defined DefaultDC like this: Create DifferentialCorrector DefaultDC; The scripting of the Vary command is not for an SQP optimizer, and the Vary panel is interpreting the panel settings correctly for a Differential Corrector.
              Hide
              djcinsb Darrel Conway added a comment -

              Please note the comment about the choice of Solver in the scripting. The panel is setting up correctly for a Differential Corrector, which is the selected Solver in the script.

              There is an issue of displaying the wrong Solver on the panel, which happens because the Vary command is inside of an Optimize branch. I do not know what the desired GUI behavior is when a user scripts the wrong type of Solver in a Solver Control Sequence, as is the case here. But I do not think that the GUI should change things – should this type of scripting error be caught when the script is loaded, or at run time?

              Regardless, the panel is correctly enabling fields for the scripted Solver. There is some cleanup required to handle the incorrect scripting, but that is a different issue (see GMT-3050) IMO.

              Show
              djcinsb Darrel Conway added a comment - Please note the comment about the choice of Solver in the scripting. The panel is setting up correctly for a Differential Corrector, which is the selected Solver in the script. There is an issue of displaying the wrong Solver on the panel, which happens because the Vary command is inside of an Optimize branch. I do not know what the desired GUI behavior is when a user scripts the wrong type of Solver in a Solver Control Sequence, as is the case here. But I do not think that the GUI should change things – should this type of scripting error be caught when the script is loaded, or at run time? Regardless, the panel is correctly enabling fields for the scripted Solver. There is some cleanup required to handle the incorrect scripting, but that is a different issue (see GMT-3050 ) IMO.
              Hide
              shoffman Shawn Hoffman added a comment -

              I noticed now that GMAT won't let the user load the script attached to this bug and the GUI issues seem to be resolved.

              Show
              shoffman Shawn Hoffman added a comment - I noticed now that GMAT won't let the user load the script attached to this bug and the GUI issues seem to be resolved.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: