Uploaded image for project: 'GMAT'
  1. GMAT
  2. GMT-2522

AdditiveScaleFactor, MultiplicativeScaleFactor descriptions wrong

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: P3
    • Resolution: Unresolved
    • Affects Version/s: R2014a, R2015a, R2016a, R2017a, R2018A
    • Fix Version/s: Someday
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

      Description

      The descriptions for AdditiveScaleFactor and MultiplicativeScaleFactor in the documentation is wrong. This affects at least the Vary reference page as well as the Architectural Spec.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            jjkparker Joel Parker added a comment -

            What's really happening here? The code looks like it's doing:

            m2 = 1/m
            x_n = (x_d + a) / m2

            which is really just:

            x_n = (x_d + a) * m

            (m = mult. scale factor, a = add. scale factor, x_d = dimensional var)

            but the reference guide and the Architectural Spec both say otherwise. The code is Vary.cpp, line 1212 and 1217.

            (the code comment pointing to Arch spec eq. 13.5 is also outdated)

            Show
            jjkparker Joel Parker added a comment - What's really happening here? The code looks like it's doing: m2 = 1/m x_n = (x_d + a) / m2 which is really just: x_n = (x_d + a) * m (m = mult. scale factor, a = add. scale factor, x_d = dimensional var) but the reference guide and the Architectural Spec both say otherwise. The code is Vary.cpp, line 1212 and 1217. (the code comment pointing to Arch spec eq. 13.5 is also outdated)
            Hide
            shughes Steven Hughes added a comment -

            CCB: P1 2013a update docs for Vary command.

            Show
            shughes Steven Hughes added a comment - CCB: P1 2013a update docs for Vary command.
            Hide
            dcooley Steve Cooley added a comment -

            Testing shows that the scaling goes as x_n = (x_d + a) * m.

            Updated the Vary command field spec to reflect this. Can the bug be closed or do we need to wait until:

            1) reference guide updated
            2) Architectural Spec updated
            3) Code comment updated

            Show
            dcooley Steve Cooley added a comment - Testing shows that the scaling goes as x_n = (x_d + a) * m. Updated the Vary command field spec to reflect this. Can the bug be closed or do we need to wait until: 1) reference guide updated 2) Architectural Spec updated 3) Code comment updated
            Hide
            dcooley Steve Cooley added a comment -

            Per 10/4/12 GMAT staff meeting, change to P3 and assign to Darrel.

            Show
            dcooley Steve Cooley added a comment - Per 10/4/12 GMAT staff meeting, change to P3 and assign to Darrel.
            Hide
            djcinsb Darrel Conway added a comment -

            This is a documentation issue, and a P3. Why did it get assigned to me for R2013a?

            Show
            djcinsb Darrel Conway added a comment - This is a documentation issue, and a P3. Why did it get assigned to me for R2013a?
            Hide
            djcinsb Darrel Conway added a comment -

            Assigned to S. Cooley to get an answer to the question

            Show
            djcinsb Darrel Conway added a comment - Assigned to S. Cooley to get an answer to the question
            Hide
            dcooley Steve Cooley added a comment -

            Per 2/13/2013 discussion with SPH, make it P3 - Someday. (See the 10/4/12 5:50 PM entry: The User's Guide is done. The other 3 documents listed can be updated later)

            Show
            dcooley Steve Cooley added a comment - Per 2/13/2013 discussion with SPH, make it P3 - Someday. (See the 10/4/12 5:50 PM entry: The User's Guide is done. The other 3 documents listed can be updated later)

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: